Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: increase snapshot to 100,000 #7160

Merged
merged 1 commit into from
Jan 15, 2017

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jan 14, 2017

Keep more wal entries in memory for fast follower recovery and less snapshots.
10,000 was a too small number that triggers quite a few compactions/snapshots.
ZK proves that 100,000 is a reasonable number for even old less powerful
machines.

Eventually we should provide both count and max memory (for large entries).

Keep more wal entries in memory for fast follower recovery.
10,000 was a too small number that triggers quite a few snapshots.
ZK proves that 100,000 is a reasonable number for even old less prowerful
machines.

Eventually we should provide both count and max memory (for large entries).
@xiang90
Copy link
Contributor Author

xiang90 commented Jan 14, 2017

/cc @heyitsanthony

@codecov-io
Copy link

Current coverage is 63.85% (diff: 100%)

No coverage report found for master at 118fd18.

Powered by Codecov. Last update 118fd18...c5a9d54

@xiang90
Copy link
Contributor Author

xiang90 commented Jan 14, 2017

travis seems went crazy.

@heyitsanthony
Copy link
Contributor

lgtm. Could you open an issue about making this smarter in the future so it can be tracked?

@xiang90
Copy link
Contributor Author

xiang90 commented Jan 14, 2017

@heyitsanthony Sure. I will open an issue to track this and merge in this PR shortly.

@xiang90
Copy link
Contributor Author

xiang90 commented Jan 15, 2017

@heyitsanthony Created issue #7162

@xiang90 xiang90 merged commit 699b1e5 into etcd-io:master Jan 15, 2017
@xiang90 xiang90 deleted the snapshotcount branch January 15, 2017 00:53
@xiang90
Copy link
Contributor Author

xiang90 commented Jan 15, 2017

@gyuho we need to set snapshot count to 10,000 for our functional tester explicitly now. We do want to trigger snapshot sending fast in our functional tester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants